Adding "id" to sublinks for custom menu icons #1542
Merged
+115
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- htdocs/kernel/module.php: Language not supported
- htdocs/modules/profile/xoops_version.php: Language not supported
- htdocs/modules/system/blocks/system_blocks.php: Language not supported
- htdocs/themes/xbootstrap5/config/module_icons.php: Language not supported
- htdocs/themes/xbootstrap5/modules/system/blocks/system_block_mainmenu.tpl: Language not supported
- htdocs/themes/xbootstrap5/style.css: Language not supported
- htdocs/themes/xbootstrap5/theme_autorun.php: Language not supported
Contributor
|
Ok, nice, for me it works on a empty (fresh installation) website.
May be add a explanation in this file, no ? (htdocs/themes/xbootstrap5/theme_autorun.php) |
Collaborator
Author
|
There will be extra tutorial, plus possibly few other other improvements, if I find the time for it. But I'm glad that you tested it and it works! In the meantime, please help with closing some of the issues here: https://github.com/XOOPS/XoopsCore25/issues |
ihackcode
approved these changes
Apr 21, 2025
montuy337513
approved these changes
Apr 23, 2025
alain01
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a detailed discussion, see: #1538