Skip to content

Conversation

@mambax7
Copy link
Collaborator

@mambax7 mambax7 commented Mar 15, 2025

No description provided.

@alain01
Copy link
Contributor

alain01 commented Mar 15, 2025

No, cause there are some hard text.

@mambax7
Copy link
Collaborator Author

mambax7 commented Mar 15, 2025

Please give more details - what hard text ?
Flash SWF format is obsolete and also a security risk, so we should get rid of it.

@alain01
Copy link
Contributor

alain01 commented Mar 15, 2025

Ligne 191.
Yes, we should remove flash
But you should use define for text, not an explicit text in english.
Sorry, I'm on phone...

@mambax7 mambax7 merged commit 0e57b49 into XOOPS:master Mar 31, 2025
4 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete the line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete the line?

Copy link
Member

@montuy337513 montuy337513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my suggestions to consider.
The code is OK.

@mambax7
Copy link
Collaborator Author

mambax7 commented Apr 11, 2025

That will be cleaned up in the RC or Final version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants