Fix problem with admin save preference #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mambax7
requested changes
Feb 4, 2025
Collaborator
mambax7
left a comment
There was a problem hiding this comment.
Seems to be OK. Thank you!
How about adding the change to prevent direct access?
mambax7
approved these changes
Feb 4, 2025
Collaborator
|
Can you add some tests, so we can make sure that it works and doesn't break something? |
Contributor
Author
How I do that ? Do you have an example ? |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context : My admin preferences (modules & main) was not always saved.
htdocs/modules/system/themes/ComposerInfo.php
I checked and found an error 404 in the browser network tab. It was from the file : htdocs/modules/system/themes/ComposerInfo.php . I comment the line but it didn't resolve the problem. But I think it's better commented.
htdocs/class/xoopssecurity.php
I found that an invalid token was aborting the save with a redirection.
The token was not saved in the session (xoops_session table) but was set correctly in $_SESSION
So I forced the updating of the session in database with add
session_write_close();htdocs/kernel/session.php
I had an SQL duplicate index error with an INSERT comment in xoops_session
The fault was this test
if (!$this->db->getAffectedRows())after and UPDATE in thepublic function write($sessionId, $data)If a row exist and is not updated (all same values),
getAffectedRowsreturn 0 and the code will try to INSERT, which cause an error (duplicate index)