Skip to content

Conversation

@ggoffy
Copy link
Contributor

@ggoffy ggoffy commented Nov 14, 2024

search result was not shown after clicking "Show all results" as if isset($nomatch) && $nomatch == true is only fulfilled if there is no match

@ggoffy ggoffy requested a review from mambax7 November 14, 2024 14:48
Copy link
Collaborator

@mambax7 mambax7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? It might be better:

<{if !isset($nomatch) || $nomatch != true}>

@ggoffy
Copy link
Contributor Author

ggoffy commented Nov 15, 2024

as it is the same it is ok for me, I have updated my PR

@mambax7 mambax7 merged commit 1c40fec into XOOPS:master Nov 16, 2024
@mambax7
Copy link
Collaborator

mambax7 commented Nov 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants