Skip to content

Conversation

@geekwright
Copy link
Contributor

Fresh install failed as follows:

ParseError: syntax error, unexpected 'else' (T_ELSE)

/xoops_lib/modules/protector/oninstall.php line 126

It appears to be a duplicated block of code. Please verify that the change is correct.

ParseError: syntax error, unexpected 'else' (T_ELSE)

/xoops_lib/modules/protector/oninstall.php line 126
@geekwright geekwright requested a review from mambax7 November 2, 2023 00:41
@mambax7
Copy link
Collaborator

mambax7 commented Nov 2, 2023

Lines 116-120 and 121-125 are the same, so we just need to remove one of them,

Copy link
Collaborator

@mambax7 mambax7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to delete the duplicate:
} else {
// Handle the error condition when opendir fails
$ret[] = 'ERROR: Could not open the directory: ' . htmlspecialchars($tpl_path) . '.
';
}

@geekwright geekwright closed this Nov 2, 2023
@geekwright geekwright deleted the install-error branch November 2, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants