Untrusted files inclusion, not guaranteed to load the right file #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoffy
approved these changes
Apr 24, 2023
geekwright
requested changes
Apr 29, 2023
Contributor
geekwright
left a comment
There was a problem hiding this comment.
I could let the snoopy change slide by, but the other issues are show stoppers.
Collaborator
Author
|
WOW!!! This is really embarrassing! And I have no idea how did it happen! |
Collaborator
Author
|
OK, it's fixed now. Once again, thanks for looking into it! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing relative paths in the include/require statements with absolute paths based on the current directory by using DIR
it ensures that the file paths are resolved relative to the directory of the current file, rather than relying on the include path.