Feature/entropy #1343
Merged
Feature/entropy #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoffy
approved these changes
Apr 24, 2023
geekwright
requested changes
Apr 29, 2023
Contributor
geekwright
left a comment
There was a problem hiding this comment.
Without the protector change, this looks fine.
htdocs/xoops_lib/modules/protector/filters_disabled/postcommon_register_insert_js_check.php
Outdated
Show resolved
Hide resolved
Remove code change as suggested by @geekwright
Collaborator
Author
|
OK, I've removed the changes in the protector file as requested, but I left the comment for PHP 7.2+, in case we want to make some updates in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.