PHP 8.0: @ Error Suppression operator does not silent fatal errors #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoffy
approved these changes
Apr 3, 2023
GregMage
reviewed
Apr 3, 2023
htdocs/class/xoopsform/form.php
Outdated
| if (!isset($var['name'])) { | ||
| $var['name'] = ''; | ||
| } | ||
| $var['name'] = sha1(get_class($object)); |
Contributor
There was a problem hiding this comment.
I don't understand what you want to do here? What does your code fix?
Collaborator
Author
There was a problem hiding this comment.
Usage of suppression operator @ in:
@$var['name'] = sha1(get_class($object));
htdocs/class/xoopsform/form.php
Outdated
| case 'md5': | ||
|
|
||
| @$var['name'] = md5(get_class($object)); | ||
| if (!isset($var['name'])) { |
Contributor
There was a problem hiding this comment.
I don't understand what you want to do here? What does your code fix?
Collaborator
Author
There was a problem hiding this comment.
Usage of suppression operator @ in:
@$var['name'] = md5(get_class($object));
| $content = rawurldecode(XoopsRequest::getText('text', '', 'POST')); | ||
|
|
||
| if (!$GLOBALS['xoopsSecurity']->validateToken(@$_POST['token'], false)) { | ||
| if (!$GLOBALS['xoopsSecurity']->validateToken(XoopsRequest::getString('token'), false)) { |
Contributor
There was a problem hiding this comment.
XoopsRequest::getString('token', '', 'POST' )?
| if (file_exists($file_to_include)) { | ||
| include_once $file_to_include; | ||
| } else { | ||
| // Handle the case when the file doesn't exist or log an error message |
Contributor
There was a problem hiding this comment.
an error message is interesting
htdocs/include/common.php
Outdated
| try { | ||
| $xoopsDB->queryF($sql); | ||
| } catch (Exception $e) { | ||
| // Handle the exception or log the error message |
Contributor
There was a problem hiding this comment.
an error message is interesting
Collaborator
Author
There was a problem hiding this comment.
I wasn't sure what would we prefer here
…ature/remove_error_suppression_operator
…ithub.com/mambax7/XoopsCore25 into feature/remove_error_suppression_operator
…ature/remove_error_suppression_operator # Conflicts: # htdocs/install/page_dbsettings.php # htdocs/install/page_pathsettings.php # htdocs/modules/system/admin/users/main.php # htdocs/xoops_lib/modules/protector/admin.php # htdocs/xoops_lib/modules/protector/main.php
IssetNode ? $conf['isocom_action'] & 1 : 0 of type integer is incompatible with the type boolean expected by parameter $sanitize of Protector::check_sql_isolatedcommentin() IssetNode ? $conf['union_action'] & 1 : 0 of type integer is incompatible with the type boolean expected by parameter $sanitize of Protector::check_sql_union()
The variable $rev_ip does not seem to be defined for all execution paths leading up to this point.
…ths leading up to this point.
It seems like $user->getVar('level') can also be of type array and array; however, parameter $value of XoopsFormRadio::__construct() does only seem to accept null|string, maybe add an additional type check?
It seems like $value can also be of type array and array; however, parameter $value of XoopsFormRadio::__construct() does only seem to accept null|string
The variable $var seems to never exist and therefore isset should always be false.
…ature/remove_error_suppression_operator # Conflicts: # htdocs/include/checklogin.php # htdocs/modules/system/class/gui.php # htdocs/xoops_lib/modules/protector/include/postcheck_functions.php
…ithub.com/mambax7/XoopsCore25 into feature/remove_error_suppression_operator # Conflicts: # htdocs/modules/system/class/gui.php # htdocs/xoops_lib/modules/protector/include/postcheck_functions.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.