Skip to content

Add German translations#369

Merged
XITRIX merged 1 commit into
XITRIX:mainfrom
soebbing:add-german-translations
Jan 8, 2025
Merged

Add German translations#369
XITRIX merged 1 commit into
XITRIX:mainfrom
soebbing:add-german-translations

Conversation

@soebbing

@soebbing soebbing commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Hi everybody!

I say that you were looking for translations of the app, so I did my best to add an accurate translation into German to it.

I also did some minor changes to the English translation, where I thought they were incorrect or sounded a bit funny.

Let me know what you think or what else needs to be done, before it can be merged!

Edit: I do not know the app very well, so some translations might be slightly misleading or too long. I'm happy to check a build, if possible, and add improvements lateron.

@sonarqubecloud

sonarqubecloud Bot commented Jan 7, 2025

Copy link
Copy Markdown

@XITRIX XITRIX merged commit d543452 into XITRIX:main Jan 8, 2025
@soebbing soebbing deleted the add-german-translations branch January 8, 2025 19:45
@XITRIX

XITRIX commented Jan 8, 2025

Copy link
Copy Markdown
Owner

Thanks a lot for your contribution! Looks good to me, I will publish ipa file to let you test localization before I will release if you'd like

https://github.com/XITRIX/iTorrent/actions/runs/12677876328

@XITRIX

XITRIX commented Jan 8, 2025

Copy link
Copy Markdown
Owner

btw there are bunch of not translated keys, do you want to leave them as they are?

image

@soebbing

soebbing commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, I saw these, but left them as is intentionally. Most of these are pretty technical things which cannot be translated directly, or are usually being used in their English original form, e.g. "Proxy" or "Seeding". I understand, that the english cases are used when no german one is provided?

It is a product for a rather technical audience, so that should be totally fine.

I need to read up on how to install an ipa directly, I don't have any experience in iOS or Mac development

@soebbing

soebbing commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

I tried installing the prod ipa using the Apple Configurator, and it transferred fine. But when I tap the icon i get a message that it could not be installed, since it's integrity could not be verified. Any idea what I need to do?

Edit: I guess I need to be enrolled in the developer program and register my device as part of your test group or something?

@XITRIX

XITRIX commented Jan 8, 2025

Copy link
Copy Markdown
Owner

No, you tried to install app signed with my certificate, basically you'll need to use AltStore (non EU) to sideload app (resign app with your account and install it)

Otherwise I can just release as is, if there is something wrong, I'll add new fixes in release after

P.S. so for empty translations I'll just reuse English variants

@soebbing

soebbing commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

I tried installing the Beta from the AltStore (I‘m in the EU), but I need to create a Patreon account first 😪

I‘ll check out the sideload with resigning tomorrow, but if you want to release it as is, I can help with textual fixes fast.

@DrHeadhunter DrHeadhunter left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants