Enabled conditional auto-sizing of Annotations#19
Merged
Conversation
- New behavior: if width is not defined, then the annotation is auto-sized to fit the text. - If the width is defined then the previous behavior of wrapping the text and (optionally) constraining height is invoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added behavior to auto-size an annotation if the annotation attribute's width is <= zero.
Description of the Change
Why Should This Be In Core?
The new behavior is desired for dynamically changing annotation text.
Benefits
The new behavior is conditional; the previous behavior is still available.
Potential Drawbacks
Unknown.