Add nil check to Dtrie.Get()#207
Merged
brianshannan-wf merged 1 commit intoWorkiva:masterfrom Mar 9, 2020
Merged
Conversation
ensures Dtrie.Get() doesn't panic on key not found
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
brianshannan-wf
approved these changes
Feb 28, 2020
Collaborator
|
Fix tabs and spaces inconsistency. |
dustinhiatt-wf
approved these changes
Mar 9, 2020
brianshannan-wf
approved these changes
Mar 9, 2020
|
RM +1 dependencies verified when consumed in tier 1 repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dtrie.Get() currently panics if called with a key that does not exist (due to calling
nil.Value()in this case). Adding a nil check here will prevent this panic from happening, and ensure that the behaviour is as described in documentation.