Wrap search label/input when needed to avoid label runt#57
Merged
Conversation
73a66a8 to
12c422e
Compare
outdoor2kode
approved these changes
Apr 11, 2023
Contributor
outdoor2kode
left a comment
There was a problem hiding this comment.
Tested and look good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
This makes the layout more flexible, to handle cases where the search label is longer than English.
Cymraeg,Română, andDeutschare good examples.I initially tried out a few ways to make the existing desktop layout work with the longer text, but didn't haven enough success. I think the fundamental fix is to make the layout adapt to the content.
The mobile and wide-desktop layouts are unaffected, but this will make the search label appear on top of the input in-between
769pxand977px.There may be a better way to design the layout at that breakpoint, this was just my rough attempt. If you see a better way please suggest it!