Changed the plugin file path for activation and uninstall hooks#378
Merged
Sephsekla merged 4 commits intoWordPress:developfrom Jul 26, 2023
Merged
Changed the plugin file path for activation and uninstall hooks#378Sephsekla merged 4 commits intoWordPress:developfrom
Sephsekla merged 4 commits intoWordPress:developfrom
Conversation
Collaborator
|
Sorry @andreg, I think the process was unclear on who needed to merge this, and that may have caused some confusion. I'll be updating the contributing documentation to make things clearer going forward. |
Contributor
Author
|
To be honest, I didn't even see any button to actually perform the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The
register_activation_hookandregister_uninstall_hookfunctions now point to the main plugin file, independently of where they are placed in the project.Why?
This change allows for the database tables to actually be created on plugin activation and destroyed on plugin uninstall.