refactor: move to TypeScript and restructure src directory#318
Merged
johnhooks merged 4 commits intoWordPress:developfrom Jul 23, 2023
Merged
refactor: move to TypeScript and restructure src directory#318johnhooks merged 4 commits intoWordPress:developfrom
johnhooks merged 4 commits intoWordPress:developfrom
Conversation
Collaborator
|
Awesome stuff! I've only scanned this but this is a massive improvement. |
Collaborator
Author
|
@Sephsekla thanks, I still need to break the css apart and put the styles directly next to the components. |
824977b to
b25ec24
Compare
Collaborator
Author
|
@Sephsekla @erikyo I'm going to walk back the attempt to split out the styling. I'm going to fix this PR to be just about the JS to TS conversion. |
e5dabc7 to
b22f2a3
Compare
b22f2a3 to
06e9c63
Compare
erikyo
approved these changes
Jul 23, 2023
Collaborator
erikyo
left a comment
There was a problem hiding this comment.
LGTM!
(a PR will follow to fix the storybook setup)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Move css related to components to their individual directories.Why?
TypeScript is great and so is organization.