This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Replace "Enable" string with "Enable auto-updates"#75
Merged
Conversation
pbiron
suggested changes
Apr 15, 2020
Contributor
pbiron
left a comment
There was a problem hiding this comment.
The changes look good to me. But...
When I pulled this branch to my local, I obviously got the dashicons, since this branch was created when those were still in `master.
When I created another local branch (off of the current master, after #74 was merged) and tried applied the diff, my local git client told me there were conflicts and couldn't apply the diff. However, GitHub says there are no conflicts. So, I think it's good to merge, but can you verify that merging it won't bring the dashicon back? If so, then it's good to go.
Does the above make sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per today’s #core-auto-updates team meeting, replace "Enable" string with "Enable auto-updates"for_ clearer interface, especially on small screens.
Fixes #72