PHP: Add listFiles options to IsomorphicLocalPHP and WebPHPEndpoint#490
PHP: Add listFiles options to IsomorphicLocalPHP and WebPHPEndpoint#490
Conversation
The options argument for listFiles was added to BasePHP in #462. This commit adds it to an interface and a Web PHP Endpoint so that it can be used across the board in web and node.js applications
|
|
||
| const zipFileName = zipFile.name; | ||
| const tmpFolder = `/tmp/assets`; | ||
| const assetNameGuess = zipFileName.replace(/\.zip$/, ''); |
There was a problem hiding this comment.
oh this wasn't meant for this PR at all, let's clean it up
|
Ah I see, when That reminds me, I was trying to get access to |
|
Yes, |
I see, I was trying to use it to pass some constants for a plugin running on the embedded site, so it can detect that it's within a custom Playground environment. It would have been convenient to have a way to persist some values across requests, but upon reflection, it makes sense the I'm still figuring out a comfortable way to communicate between the Playground host and the code running on the embedded website. So far I've been using a queue of messages in the database to send and receive data/actions.
The number of places where Anyway, I'm enjoying getting familiar with the code, learning the logic and thoughts behind it. |
Would the |
|
@eliot-akira I just opened #514 to keep track of the complexity issue |
The options argument for listFiles was added to BasePHP in #462. This commit adds it to an interface and a Web PHP Endpoint so that it can be used across the board in web and node.js applications
To test, confirm the CI is green.
Note for the future: Ideally something would flash red in the CI if BasePHP interface is updated without adjusting the other to. I completely forgot about them.
cc @eliot-akira