BasePHP: Use FS.rename for mv method#445
Merged
adamziel merged 2 commits intoWordPress:trunkfrom May 25, 2023
Merged
Conversation
The FS method is called rename, not mv, in both Emscripten and Node.js. - https://emscripten.org/docs/api_reference/Filesystem-API.html#FS.rename - https://nodejs.org/api/fs.html#fsrenameoldpath-newpath-callback
Collaborator
|
This is great @eliot-akira, thank you so much for finding and fixing this at the framework level – this benefits every Playground project! |
adamziel
approved these changes
May 25, 2023
Collaborator
|
Would you also add a unit test to prevent any future regressions? They live in |
Collaborator
Author
|
Sure, I added the following tests:
|
Collaborator
|
10/10 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update
BasePHP.mvmethod to useFS.renameinstead ofFS.mvwhich doesn't exist.Why?
The FS method is called
rename, notmv, in both Emscripten and Node.js.Testing Instructions
npx nx test php-wasm-node.