fix(CLI): reset crash on newer Node versions (rmdir → rm).#3695
Merged
adamziel merged 1 commit intoMay 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the CLI reset behavior to avoid crashes on newer Node.js versions by replacing deprecated fs.rmdirSync(..., { recursive: true }) usage with fs.rmSync(...).
Changes:
- Replace
rmdirSyncimport withrmSync - Use
rmSync(hostPath, { recursive: true, force: true })when--resetis enabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1879
to
1883
| if (existsSync(hostPath) && (args['reset'] as boolean)) { | ||
| cliOutput.print('Resetting site...'); | ||
| rmdirSync(hostPath, { recursive: true }); | ||
| rmSync(hostPath, { recursive: true, force: true }); | ||
| } | ||
| mkdirSync(hostPath, { recursive: true }); |
Collaborator
|
Thank you @vipul0425! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Fixes #3538
Implementation details
Node.js deprecated the
{ recursive: true }option offs.rmdirSync()long ago and has since removed it. Replaced the callfs.rmSync(..., { recursive: true, force: true }), the documented replacement.Testing Instructions
On Node 25