[Website] Fix Safari loading stale index.html after deployments#3208
Merged
[Website] Fix Safari loading stale index.html after deployments#3208
Conversation
Safari doesn't respect cache: 'no-cache' the same way Chrome and Firefox do. When fetching /index.html with no-cache, Safari would still serve the response from its HTTP cache. This caused problems after new Playground deployments—the stale cached index.html contained references to assets that no longer existed on the server, breaking the site. Switching to cache: 'no-store' makes Safari behave consistently with other browsers by always going to the network without checking the HTTP cache first. This ensures users get fresh assets after each deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safari doesn't respect
cache: 'no-cache'the same way Chrome and Firefox do. When fetching /index.html with no-cache, Safari would still serve the response from its HTTP cache. This caused problems after new Playground deployments—the stale cached index.html contained references to assets that no longer existed on the server, breaking the site.This PR switches to
cache: 'no-store'in all fetch operations, which makes Safari behave consistently with other browsers by always going to the network without checking the HTTP cache first.Changes
cache: 'no-cache'withcache: 'no-store'innetworkFirstFetch()cacheOfflineModeAssetsForCurrentRelease()andfetchFresh()Test plan