Decode HTML entities in JS instead of PHP for site name retrieval#3190
Draft
Decode HTML entities in JS instead of PHP for site name retrieval#3190
Conversation
Adds a dropdown to the backup reminder UI that lets users schedule automatic backup downloads on a daily, every-2-days, or weekly basis. When enabled, the toolbar backup indicator is hidden and backups trigger automatically after WordPress boots.
Remove redundant daysUsedSinceLastBackup tracking. The backup indicator now derives days since last backup directly from backupHistory timestamps, which is simpler and more reliable.
Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com>
Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update backup reminder UI for secure entity decoding in JS
Decode HTML entities in JS instead of PHP for site name retrieval
Jan 26, 2026
Collaborator
|
@copilot retry |
Contributor
Author
All checks verified and passing: The implementation is complete - PHP now outputs raw |
adamziel
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per review feedback on #3162, move HTML entity decoding from PHP to JavaScript to follow separation of concerns and security best practices.
Changes:
echo $nameinstead ofecho html_entity_decode($name, ENT_QUOTES, 'UTF-8')decodeHTMLEntities()using DOM-based decoding to safely decode entities while preventing XSSImplementation:
This approach leverages the browser's native entity decoding without introducing parsing vulnerabilities.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.