Skip to content

Improve Browser Chrome Proportions & Responsive Display#1242

Closed
0aveRyan wants to merge 10 commits intoWordPress:trunkfrom
0aveRyan:improve/browser-chrome-proportions-and-display
Closed

Improve Browser Chrome Proportions & Responsive Display#1242
0aveRyan wants to merge 10 commits intoWordPress:trunkfrom
0aveRyan:improve/browser-chrome-proportions-and-display

Conversation

@0aveRyan
Copy link
Copy Markdown
Contributor

@0aveRyan 0aveRyan commented Apr 14, 2024

What is this PR doing?

  • 📰 Update fonts to (largely) use system font stacks.
  • 📐 Improves sizing and proportion of chrome to be smaller and better-reflect real-world OS proportions.
  • ↔️ Improves responsive collapse of Playground when not in fullscreen/seamless.
  • 🔴 Adds reset site functionality (with warning dialog) to red close slot
  • ↕️ Add arrow hover-states to buttons
  • 👀 Wrap pulsing browser animation in check for prefers reduce motion and fallback to box shadow.

What problem is it solving?

  • Helps browser chrome be more-accurate and take up fewer pixels at all screen sizes
  • Helps playground collapse better at mobile viewports
  • Small improvements for cross-platform/browser render and respecting motion preferences.

old chrome screenshot
new chrome screenshot
Button hover states

Copy link
Copy Markdown
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @0aveRyan! I left one comment related to the default storage, but otherwise it all looks good.

@bgrgicak bgrgicak self-requested a review April 16, 2024 04:54
Copy link
Copy Markdown
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamziel how does the improved bar look to you?

Copy link
Copy Markdown
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0aveRyan there are a few linter issues that need fixing.

…o improve/browser-chrome-proportions-and-display
@0aveRyan 0aveRyan closed this Aug 26, 2024
@0aveRyan 0aveRyan deleted the improve/browser-chrome-proportions-and-display branch August 27, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants