wp_die() updates for Media Component#9966
wp_die() updates for Media Component#9966CallumBW95 wants to merge 6 commits intoWordPress:trunkfrom
Conversation
…s related to the media component
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mindctrl
left a comment
There was a problem hiding this comment.
Left some feedback about one of the status codes.
| $attachment = get_post( $this->id ); | ||
| if ( empty( $attachment ) ) { | ||
| wp_die( __( 'Please select a file' ) ); | ||
| wp_die( __( 'Please select a file' ), 120 ); |
There was a problem hiding this comment.
This is the incorrect code. According to your table in the Trac ticket, it should be 400. (120 was the line number in the file).
mindctrl
left a comment
There was a problem hiding this comment.
Looks good. Left a question about 415 instead of 422. Thoughts?
Co-authored-by: John Parris <public@johnparris.com>
Update wp_die() to include status codes where appropriate within files related to the Media component.
Trac ticket: 64010
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.