63920 Corrected is_wp_error Check#9861
63920 Corrected is_wp_error Check#9861IshikaBansal95 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Ishika.bansal2xecurify.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Hello! I'm curious about your PR here, and if you factored in the existing patch from @kitchin as proposed on the ticket? That patch has been iterated on by @mindctrl with added unit tests in #9863 so it's likely to be what gets committed. |
Added the is_wp_error check before calling other array functions so that no warning is thrown.
Trac ticket: https://core.trac.wordpress.org/ticket/63920
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.