#63932 Disable the failing Imagick tests#9749
#63932 Disable the failing Imagick tests#9749johnbillion wants to merge 13 commits intoWordPress:trunkfrom
Conversation
… to the mysql client.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
left a comment
There was a problem hiding this comment.
Few small comments, but looks good overall!
| * | ||
| * // Temporarily disabled until we can figure out why it fails on the Trixie based PHP container. | ||
| * // See https://core.trac.wordpress.org/ticket/63932. | ||
| * @requires PHP < 8.3 |
There was a problem hiding this comment.
Worth noting that this will eventually need to be changed to PHP < 8.1 should a security update be released for 8.1 & 8.2.
I think referencing the ticket is OK for now.
There was a problem hiding this comment.
Would it be better to do this in the test where we can check the imagemagick version using Imagick::getVersion()? I don't have a strong opinion but it should make the concern about future containers go away
This temporarily disables failing Imagick tests prior to investigation.
Adds some missing
WP_Errorassertions too which means an error will be a failure instead.Branches from #9746
Trac ticket: https://core.trac.wordpress.org/ticket/63932
Trac ticket: https://core.trac.wordpress.org/ticket/63876