Skip to content

63836: add error codes to wp_die in post.php#9604

Closed
CallumBW95 wants to merge 7 commits intoWordPress:trunkfrom
CallumBW95:63836-wp_die-status-codes
Closed

63836: add error codes to wp_die in post.php#9604
CallumBW95 wants to merge 7 commits intoWordPress:trunkfrom
CallumBW95:63836-wp_die-status-codes

Conversation

@CallumBW95
Copy link
Copy Markdown

@CallumBW95 CallumBW95 commented Aug 26, 2025

Add error codes to each instance of wp_die in ./src/wp-admin/post.php

Trac ticket: 63836


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Hi @CallumBW95! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props callumbw95, johnbillion, sergeybiryukov, timothyblynjacobs, jeremyfelt, nerrad.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

johnbillion and others added 6 commits August 26, 2025 19:29
…s to an earlier digest to work around issues with the newer images.

This pins the images to PHP 8.3.10 and 8.4.11 on Debian Bullseye pending further investigation into the root cause of the certificate verification failure affecting the connection to the database containers.

This also removes memcached from the test matrix pending further investigation into the missing Memcached executable.

Props desrosj, bernhard-reiter, SirLouen, johnbillion.

See #63876

git-svn-id: https://develop.svn.wordpress.org/trunk@60660 602fd350-edb4-49c9-b593-d223f7449a82
…ms()`.

`get_term()` can return `WP_Error` or `null` on failure, so the result should be verified as a `WP_Term` instance before accessing the `count` property.

This commit prevents a PHP warning if `get_term()` returns `null` for a child term:
{{{
Warning: Attempt to read property "count" on null
}}}

Follow-up to [27458], [37572].

Props josephscott, coleatkinson1, kebbet, jakariaistauk, sabernhardt, westonruter, SergeyBiryukov.
Fixes #63877.

git-svn-id: https://develop.svn.wordpress.org/trunk@60661 602fd350-edb4-49c9-b593-d223f7449a82
Previously, the textarea control was forced to use 5 rows. This commit instead applies a default value of 5, but allows for a developer to specify a different number of rows using the input_attrs arg.

Props sirlouen, timhavinga, celloexpressions, sainathpoojary. 
Fixes #47445.


git-svn-id: https://develop.svn.wordpress.org/trunk@60662 602fd350-edb4-49c9-b593-d223f7449a82
Removes a new line added as part of [60611] which impacted alignment of variable assignments in `process_block_bindings()`.

See #63168.


git-svn-id: https://develop.svn.wordpress.org/trunk@60663 602fd350-edb4-49c9-b593-d223f7449a82
Props dmsnell.
See [60662].


git-svn-id: https://develop.svn.wordpress.org/trunk@60664 602fd350-edb4-49c9-b593-d223f7449a82
As part of a larger effort in #63694, this utlizes `WP_HTML_Tag_Processor` instead of regex to parse the string passed into `get_url_in_content`.

As a benefit this also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`.

Developed in: WordPress#9272
Discussed in: https://core.trac.wordpress.org/ticket/63694

Props dmsnell, jonsurrell, nerrad.
Fixes #63694.

git-svn-id: https://develop.svn.wordpress.org/trunk@60665 602fd350-edb4-49c9-b593-d223f7449a82
@CallumBW95 CallumBW95 closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants