Twenty Twenty: Fix font inconsistency in Latest Posts block editor#9455
Twenty Twenty: Fix font inconsistency in Latest Posts block editor#9455R1shabh-Gupta wants to merge 3 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @samykantari. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hello from the contribution day at whodunit, Before After |
|
Thanks for providing the test report, @samykantari. |
sabernhardt
left a comment
There was a problem hiding this comment.
The selectors only need the one class to override the serif font.
| margin-top: 15px; | ||
| } | ||
|
|
||
| .editor-styles-wrapper .wp-block-latest-posts__post-full-content p { |
There was a problem hiding this comment.
| .editor-styles-wrapper .wp-block-latest-posts__post-full-content p { | |
| .wp-block-latest-posts__post-full-content p { |
These do not need the .editor-styles-wrapper class in either editor (post or widgets).
| margin-top: 15px; | ||
| } | ||
|
|
||
| .editor-styles-wrapper .wp-block-latest-posts__post-full-content p { |
There was a problem hiding this comment.
| .editor-styles-wrapper .wp-block-latest-posts__post-full-content p { | |
| .wp-block-latest-posts__post-full-content p { |
sabernhardt
left a comment
There was a problem hiding this comment.
Thanks for changing the selectors. However, I missed the extra space character before the tab in each rule. #10468 only has the tab, so I tested that PR instead.
| } | ||
|
|
||
| .wp-block-latest-posts__post-full-content p { | ||
| font-family: inherit; |
There was a problem hiding this comment.
| font-family: inherit; | |
| font-family: inherit; |
| } | ||
|
|
||
| .wp-block-latest-posts__post-full-content p { | ||
| font-family: inherit; |
There was a problem hiding this comment.
| font-family: inherit; | |
| font-family: inherit; |
|
@samykantari I added props for your contribution toward r61189. If you connect your GitHub and WordPress profiles, credit should be easier to assign to leprincenoir in the future. (I also manually added props for viralsampat, sainathpoojary, im3dabasia1, and wildworks.) |
Trac ticket: https://core.trac.wordpress.org/ticket/63798
Fixes a font styling inconsistency in the Twenty Twenty theme where the Latest Posts block displays post content in different fonts between the editor and frontend when "Full post" content is selected.
NOTE: I created this PR alongside the patch to make testing and updates easier.
Testing
Steps to reproduce the issue:
Expected result: Font styling should now match between editor and frontend views.
Screenshots
Before
Editor
Frontend
After
Editor
Frontend