Use API for MariaDB version test#9009
Use API for MariaDB version test#9009todeveni wants to merge 3 commits intoWordPress:trunkfrom todeveni:trac-63586
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
If the version is unlisted we can fail the test immediately and avoid the need to fake the date when it's unknown.
tests/phpunit/tests/readme.php
Outdated
| // If the release ID is not found, expect it to be an EOL release and return one day before the current date. | ||
| if ( ! isset( $mariadb_eol ) ) { | ||
| $mariadb_eol = gmdate( 'Y-m-d', strtotime( '-1 day' ) ); | ||
| } |
There was a problem hiding this comment.
| // If the release ID is not found, expect it to be an EOL release and return one day before the current date. | |
| if ( ! isset( $mariadb_eol ) ) { | |
| $mariadb_eol = gmdate( 'Y-m-d', strtotime( '-1 day' ) ); | |
| } | |
| // If the release ID is not found the version is unsupported. | |
| if ( ! isset( $mariadb_eol ) ) { | |
| $this->fail( "{$matches[1]} is not included in MariaDB's list of supported versions. Remember to update the WordPress.org Requirements page, too." ); | |
| } |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Code looks good and tests well when hacking readme.html to list an EOL version.
Thank you!
Use data from MariaDB API and re-enable test.
This patch assumes that when a release is missing from said API, it'll be EOL.
Trac ticket: https://core.trac.wordpress.org/ticket/63586