Fixed draft posts page allowed querying#8919
Fixed draft posts page allowed querying#8919anukasha-mo wants to merge 6 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
e831ee0 to
188cec3
Compare
| $posts_page = get_post( $this->queried_object_id ); | ||
| if ( ! $posts_page || 'draft' == $posts_page->post_status ) { | ||
| $this->set_404(); | ||
| return; |
There was a problem hiding this comment.
I don't think this can return here because then it means parse_query will never fire at the end of this method. Similarly query_vars_hash won't be set nor will query_vars_changed.
| $posts_page = get_post( $query_vars['page_id'] ); | ||
| if ( ! $posts_page || 'draft' == $posts_page->post_status ) { | ||
| $this->set_404(); | ||
| return; |
|
|
||
| if ( 'page' === get_option( 'show_on_front' ) && isset( $this->queried_object_id ) && get_option( 'page_for_posts' ) == $this->queried_object_id ) { | ||
| $posts_page = get_post( $this->queried_object_id ); | ||
| if ( ! $posts_page || 'draft' == $posts_page->post_status ) { |
There was a problem hiding this comment.
What if the user has the capability of previewing this status?
| if ( $query_vars['page_id'] ) { | ||
| if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) == $query_vars['page_id'] ) { | ||
| $posts_page = get_post( $query_vars['page_id'] ); | ||
| if ( ! $posts_page || 'draft' == $posts_page->post_status ) { |
Added checks in two places where WordPress determines if a page is the posts page:
In both cases, we now:
Trac ticket: https://core.trac.wordpress.org/ticket/60566
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.