Skip to content

Proposal to use a short circuit filter#8633

Closed
lloc wants to merge 23 commits intoWordPress:trunkfrom
lloc:61146-marking-user-account
Closed

Proposal to use a short circuit filter#8633
lloc wants to merge 23 commits intoWordPress:trunkfrom
lloc:61146-marking-user-account

Conversation

@lloc
Copy link

@lloc lloc commented Apr 1, 2025

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props realloc, westonruter, audrasjb, shailu25, spacedmonkey.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

lloc and others added 3 commits October 23, 2025 10:57
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Shail Mehta <shailmehta25@gmail.com>
lloc and others added 2 commits October 27, 2025 15:55
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@lloc lloc requested a review from westonruter October 27, 2025 15:36
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests will need to be added for this change as well.

lloc and others added 6 commits October 28, 2025 09:57
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
lloc and others added 4 commits November 3, 2025 16:21
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
lloc and others added 4 commits November 3, 2025 16:23
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@westonruter westonruter requested review from JJJ and removed request for shail-mehta November 4, 2025 00:57
@westonruter
Copy link
Member

Review from Gemini:

The changes in src/wp-admin/network/users.php are well-implemented and adhere to WordPress coding standards.

Here's a summary of the review:

  • HTTP Status Codes: Explicitly adding 403 to wp_die() calls for unauthorized actions is a good practice for proper HTTP response handling.
  • New Filter: The introduction of the network_user_spam_propagate_to_blogs filter provides valuable flexibility for developers to control spam status propagation. The associated PHPDoc block is correctly formatted and includes the @since 6.9.0 tag, parameter descriptions, and type hints.
  • Security Enhancement: The addition of is_super_admin() checks for both "spam" and "notspam" actions prevents unauthorized modification of network administrators, which is a significant security improvement.
  • Multi-network Compatibility: The refinement in the "notspam" logic to include && get_current_network_id() === $details->site_id ensures that blog status updates are correctly scoped to the current network, improving behavior in multi-network installations.
  • Indentation and Readability: The code maintains consistent indentation and remains highly readable.

Overall, these changes improve security, flexibility, and correctness within the WordPress network user management.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look good to me. However, I defer to @JJJ for final approval since he is much more familiar with multisite.

@westonruter westonruter requested a review from Copilot February 9, 2026 18:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61660
GitHub commit: cf065b7

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants