Skip to content

Fix: remove _doing_it_wrong notice and early return in WP_Theme:is_block_theme #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dinhtungdu wants to merge 1 commit into from
Closed

Fix: remove _doing_it_wrong notice and early return in WP_Theme:is_block_theme #8508

dinhtungdu wants to merge 1 commit into from

Conversation

@dinhtungdu
Copy link
Member

@dinhtungdu dinhtungdu commented Mar 14, 2025 •
edited
Loading

This PR partially reverts https://core.trac.wordpress.org/changeset/59968 by removing the warning notice and early return in WP_Theme::is_block_theme(), which causes issues if active plugins call wp_is_block_theme() early. It's safe for plugins to call wp_is_block_theme() anytime so the early return and notice should be removed.

  • wp_is_block_theme doesn't need to be called after after_theme_setup, it just needs to be called after theme directories have been registered.
  • The initial issue with the child theme is caused by calling that function after creating post types, which is before the theme directories registration.
  • Moving that logic to after_theme_setup, as we did in https://core.trac.wordpress.org/changeset/59968, is enough to solve the issue.
  • Plugins can never break the theme resolution because they are loaded after theme directories registration.

Trac ticket: https://core.trac.wordpress.org/ticket/63086

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dinhtungdu, afragen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Mar 14, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dinhtungdu dinhtungdu changed the title Fix: remove warning and early return in WP_Theme:is_block_theme Fix: remove _doing_it_wrong notice and early return in WP_Theme:is_block_theme Mar 15, 2025
@afragen
Copy link
Member

afragen commented Mar 16, 2025 •
edited
Loading

Absolutely agree. This is filling up my logs and not sure it's even effecting function as I'm sure it's used in a plugin.

@dinhtungdu
Copy link
Member Author

dinhtungdu commented Mar 18, 2025

Closing in favor of #8526

@dinhtungdu dinhtungdu closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dinhtungdu @afragen