Skip to content

Comments: Email check for non logged in users#8443

Open
Infinite-Null wants to merge 3 commits intoWordPress:trunkfrom
Infinite-Null:fix/moderate-registered-email-comments
Open

Comments: Email check for non logged in users#8443
Infinite-Null wants to merge 3 commits intoWordPress:trunkfrom
Infinite-Null:fix/moderate-registered-email-comments

Conversation

@Infinite-Null
Copy link

@Infinite-Null Infinite-Null commented Mar 3, 2025

Trac Ticket: #10931

Description:

This PR addresses the issue, When a non-logged-in user submits a comment using an email address that belongs to a registered user, the comment is now automatically sent to the moderation queue instead of being published directly.

Screencast:

Before Patch:

Screen.Recording.2025-03-04.at.12.15.50.PM.mov

After Patch:

Screen.Recording.2025-03-04.at.12.10.37.PM.mov

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Infinite-Null Infinite-Null marked this pull request as ready for review March 4, 2025 06:50
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, adamsilverstein.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Infinite-Null Infinite-Null force-pushed the fix/moderate-registered-email-comments branch from 1dcb253 to d406fe2 Compare April 23, 2025 06:47
/**
* @ticket 10931
*/
public function test_should_return_false_when_non_logged_in_user_uses_registered_email() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function test_should_return_false_when_non_logged_in_user_uses_registered_email() {
public function test_wp_check_comment_data_should_return_false_when_non_logged_in_user_uses_registered_email() {

@Infinite-Null
Copy link
Author

Hi @adamsilverstein,
Thank you for the review. I have made the necessary changes. Please review the PR at your convenience. Thank you. 🙌

@Infinite-Null Infinite-Null changed the title Email check for non logged in users Comments: Email check for non logged in users Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants