Skip to content

Force npm install in sync-gutenberg-packages script to use .npmrc config#8431

Closed
jtquip88 wants to merge 1 commit into
WordPress:trunkfrom
jtquip88:sync-gutenberg-packages
Closed

Force npm install in sync-gutenberg-packages script to use .npmrc config#8431
jtquip88 wants to merge 1 commit into
WordPress:trunkfrom
jtquip88:sync-gutenberg-packages

Conversation

@jtquip88

@jtquip88 jtquip88 commented Feb 28, 2025 •
edited
Loading

Copy link
Copy Markdown

npm install in sync-gutenberg-packages script is not respecting settings specified in .npmrc file. To troubleshoot, I ran npm config list from inside the sync-gutenberg-packages script and observed the following output.

; engine-strict = true ; overridden by env
; legacy-peer-deps = true ; overridden by env
; lockfile-version = "3" ; overridden by env
; prefer-dedupe = true ; overridden by env
; save-exact = true ; overridden by env
; save-prefix = "" ; overridden by env

This indicates .npmrc settings are being overridden by environment variables. This means the behavior might differ based on where script is ran. Made a change to explicitly use local .npmrc file while issuing npm install command.

I also observed the issue with parsing packageLock dependencies.

const versionConflicts = Object.entries( packageLock.dependencies )
TypeError: Cannot convert undefined or null to object

This is due to the fact that in generated package-lock.json file, dependencies are not a top level property/field, rather it is nested inside packages i.e each package. As a result, packageLock.dependencies is undefined. This needs some more investigation so I am hoping to raise a separate PR for that.

Trac ticket: https://core.trac.wordpress.org/ticket/62839

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Feb 28, 2025 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jtquip88, sirlouen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Feb 28, 2025

Copy link
Copy Markdown

Hi @jtquip88! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

github-actions Bot commented Feb 28, 2025

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj requested review from Mamaduka, desrosj and gziolo March 3, 2025 15:14
@SirLouen

SirLouen commented Apr 2, 2025

Copy link
Copy Markdown
Member

@jtquip88 please check this

desrosj
desrosj requested changes Jul 2, 2025
View reviewed changes
Comment thread tools/release/sync-gutenberg-packages.js
const currentPackages = getWordPressPackages( currentPackageJSON );

const packageLock = readJSONFile( "package-lock.json" );
console.log("JT ->");

@desrosj desrosj Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this chunk related to the secondary issue you noted? I think we should split that out into a different bug report on Trac to separate it out as it may be a bit more involved..

@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62062
GitHub commit: 1ed4e1a

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desrosj desrosj desrosj requested changes

@gziolo gziolo Awaiting requested review from gziolo

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtquip88 @SirLouen @desrosj