CSS: Reduce colors used in wp-admin#818
Closed
ryelle wants to merge 3 commits into
Closed
Conversation
ryelle
commented
Dec 15, 2020
| @@ -1,3 +1,4 @@ | |||
| /* @no-color-match */ | |||
Contributor
Author
There was a problem hiding this comment.
This is just for the automated replacement tool, it should be removed before this is merged.
|
The "back to the PR" link on the before & after page doesn't have an |
Contributor
Author
|
@danfarrow Thanks for catching that— I put up the page before the PR was created, and forgot to update it. |
4260e44 to
cffbb5d
Compare
cffbb5d to
c385a73
Compare
Contributor
Author
|
Based on feedback on the ticket, I've added another valid grey,
|
Contributor
Author
|
Merged in [50025] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a longer project in cleaning up core's admin CSS; eventually making color schemes easier and a dark mode possible. It collapses all colors used in the CSS to one of the colors listed in this color palette.
In the short-term, it also visually cleans up the admin, and should help any newer projects make design decisions with consistency.
The process was initially automated, with some very basic manual cleanup, so it should be visually checked for contrast and if anything's off with the design.
See some before & after screenshots here.
This brings down the total number of colors used in core CSS down to 97 unique values (from 258 ❗ ).
Trac ticket: https://core.trac.wordpress.org/ticket/49999
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.