Skip to content

Conversation

@pbearne
Copy link

@pbearne pbearne commented Dec 30, 2024

Introduced comprehensive PHPUnit tests to cover various scenarios for the get_calendar() function. Enhanced input validation in get_calendar() to handle invalid week numbers and months, defaulting them to safe values when out of range.

Trac ticket: https://core.trac.wordpress.org/ticket/41011

Introduced comprehensive PHPUnit tests to cover various scenarios for the `get_calendar()` function. Enhanced input validation in `get_calendar()` to handle invalid week numbers and months, defaulting them to safe values when out of range.
@github-actions
Copy link

github-actions bot commented Dec 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, audrasjb, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Introduced comprehensive PHPUnit tests to cover various scenarios for the `get_calendar()` function. Enhanced input validation in `get_calendar()` to handle invalid week numbers and months, defaulting them to safe values when out of range.
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review.

Add @ticket annotation for all the new unit tests.

pbearne and others added 4 commits December 31, 2024 10:44
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@audrasjb
Copy link
Contributor

audrasjb commented Mar 6, 2025

Thanks for the PR @pbearne! Would you mind updating it to resolve the conflicts? Thanks!

@audrasjb
Copy link
Contributor

It appears some tests are failing @pbearne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants