Add a filter to customize the URL for page caching check in Site Health#7426
Add a filter to customize the URL for page caching check in Site Health#7426zetrider wants to merge 8 commits intoWordPress:trunkfrom
Conversation
|
Hi @zetrider! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
… url into the test description line.
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks. The changes looks good to me.
|
@zetrider could you address the outstanding feedback? It's couple of small things and I believe this could be ready for merge. |
Yes. Once the feedback addressed i will approve and move the ticket in 6.8 milestone for visibility |
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
|
Thanks guys, good catch, done. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks for the updates. One final doc changes.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
| * | ||
| * @return string The URL for checking page caching. | ||
| */ | ||
| public function get_persistent_page_cache_url() { |
There was a problem hiding this comment.
This shouldn't be a public method that we have to maintain. If anything it should be private, but I don't think we need an extra method for this in the first place.
| * | ||
| * @param string $url The URL used for checking page caching. Default home URL. | ||
| */ | ||
| return apply_filters( 'site_status_persistent_page_cache_url', home_url( '/' ) ); |
There was a problem hiding this comment.
The original ticket mentions desire to test multiple different sites, for example on a multilingual or ecommerce site. But this is not possible if this is just a single filterable URL.
If testing of multiple pages is desired, then this should be an array of URLs.
Trac ticket: https://core.trac.wordpress.org/ticket/62101
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.