Build/Test Tools: Enable running the tests on PHP 8.4 (Trac: 62061)#7379
Build/Test Tools: Enable running the tests on PHP 8.4 (Trac: 62061)#7379jrfnl wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
9c2883d to
b8e8ce3
Compare
|
Rebased without changes on current Note: I propose to temporarily skip those 7 tests until SimplePie and the Importer plugin are fixed and the fixes released. Enabling the test runs against PHP 8.4 and not allowing them to fail should then prevent new issues from being introduced. |
b8e8ce3 to
607572b
Compare
PHP 8.4 is expected to be released at the end of November 2024. Trac ticket 62061 contains a full analysis of the changes needed for WP to be ready for PHP 8.4 and all currently available patches for WP Core have been merged in the mean time. Enabling the tests to run in CI on PHP 8.4 allows WordPress core to prevent new PHP 8.4 compatibility issues from being introduced. Notes: * While a [patch has been pulled](WordPress/wordpress-importer#172) for the Importer plugin, this patch has not been merged yet. This means there are currently still five failing tests. These failure are directly related to the Importer plugin and will be fixed once the PR for the plugin has been merged. To still allow WP Core to start structurally testing against PHP 8.4, these five tests have been set up now to be skipped on PHP 8.4. These tests skips should be removed again once the PR to the plugin has been merged. * Xdebug-related tests will not be run on PHP 8.4 at this time as the Docker image for PHP 8.4 does not contain Xdebug yet. Once a stable release of Xdebug 3.4.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.4.
163dab2 to
d91e1ce
Compare
|
Update: I've updated the commit to:
A build showing a "clean bill of health" for WP Core using the updated version of the workflow can be seen here: https://github.com/WordPress/wordpress-develop/actions/runs/11164654907 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
PHP 8.4 is expected to be released at the end of November 2024.
Trac ticket 62061 contains a full analysis of the changes needed for WP to be ready for PHP 8.4 and all currently available patches for WP Core have been merged in the mean time.
Enabling the tests to run in CI on PHP 8.4 allows WordPress core to prevent new PHP 8.4 compatibility issues from being introduced.
Notes:
This means there are currently still five failing tests. These failure are directly related to the Importer plugin and will be fixed once the PR for the plugin has been merged.
To still allow WP Core to start structurally testing against PHP 8.4, these five tests have been set up now to be skipped on PHP 8.4.
These tests skips should be removed again once the PR to the plugin has been merged.
Trac ticket: https://core.trac.wordpress.org/ticket/62061
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.