Skip to content

61898 - Use --wp-admin--admin-bar--height variable in css#7219

Closed
nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
nirav7707:61900-use--wp-admin--admin-bar--heigh-var-in-css
Closed

61898 - Use --wp-admin--admin-bar--height variable in css#7219
nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
nirav7707:61900-use--wp-admin--admin-bar--heigh-var-in-css

Conversation

@nirav7707
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @tdrayson.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props niravsherasiya7707, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tdrayson
Copy link
Copy Markdown

This may need to be looked into further as there are other areas that use the hardcoded value for the admin bar height. For example the media query sets it to 46px hardcoded

I think there are other places that the hardcoded value is use too. The css variable has the media query value set for small breakpoints.

There is also the common-rtl.css that I know needs updating, and probably some other files that use the hardcoded value.

(wasn't sure how to leave a comment on the Trac ticket, sorry if this isn't the best place to leave)

@SergeyBiryukov
Copy link
Copy Markdown
Member

Thanks for the PR! Merged in r58929.

This may need to be looked into further as there are other areas that use the hardcoded value for the admin bar height. For example the media query sets it to 46px hardcoded

Good catch, it should be safe to also use the CSS variable here, as it is set to 46px for the max-width: 782px breakpoint.

There is also the common-rtl.css that I know needs updating, and probably some other files that use the hardcoded value.

The common-rtl.css is updated automatically by a build task, no need to patch in manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants