61898 - Use --wp-admin--admin-bar--height variable in css#7219
61898 - Use --wp-admin--admin-bar--height variable in css#7219nirav7707 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tdrayson. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
This may need to be looked into further as there are other areas that use the hardcoded value for the admin bar height. For example the media query sets it to 46px hardcoded I think there are other places that the hardcoded value is use too. The css variable has the media query value set for small breakpoints. There is also the (wasn't sure how to leave a comment on the Trac ticket, sorry if this isn't the best place to leave) |
|
Thanks for the PR! Merged in r58929.
Good catch, it should be safe to also use the CSS variable here, as it is set to
The |
Resolves - https://core.trac.wordpress.org/ticket/61898