HTML API: Remove completed todo comments#7174
Closed
sirreal wants to merge 3 commits intoWordPress:trunkfrom
Closed
HTML API: Remove completed todo comments#7174sirreal wants to merge 3 commits intoWordPress:trunkfrom
sirreal wants to merge 3 commits intoWordPress:trunkfrom
Conversation
This was addressed in https://core.trac.wordpress.org/changeset/58870
These "has in scope" functions were fixed to match HTML nodes or namespaced nodes in https://core.trac.wordpress.org/changeset/58867
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Aug 10, 2024
This patch removes TODO comments indicating the need to verify certain behaviors and algorithms. Those verifications have taken place and the comments are no longer needed. Developed in #7174 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58867], [58870]. Props jonsurrell. See #64646. git-svn-id: https://develop.svn.wordpress.org/trunk@58877 602fd350-edb4-49c9-b593-d223f7449a82
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Aug 10, 2024
This patch removes TODO comments indicating the need to verify certain behaviors and algorithms. Those verifications have taken place and the comments are no longer needed. Developed in WordPress/wordpress-develop#7174 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58867], [58870]. Props jonsurrell. See #64646. Built from https://develop.svn.wordpress.org/trunk@58877 git-svn-id: https://core.svn.wordpress.org/trunk@58273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 10, 2024
This patch removes TODO comments indicating the need to verify certain behaviors and algorithms. Those verifications have taken place and the comments are no longer needed. Developed in WordPress/wordpress-develop#7174 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58867], [58870]. Props jonsurrell. See #64646. Built from https://develop.svn.wordpress.org/trunk@58877 git-svn-id: http://core.svn.wordpress.org/trunk@58273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
aslamdoctor
pushed a commit
to aslamdoctor/wordpress-develop
that referenced
this pull request
Dec 28, 2024
This patch removes TODO comments indicating the need to verify certain behaviors and algorithms. Those verifications have taken place and the comments are no longer needed. Developed in WordPress#7174 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58867], [58870]. Props jonsurrell. See #64646. git-svn-id: https://develop.svn.wordpress.org/trunk@58877 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/61646
Remove todo comments related to work that has been completed.
The
expects_closertodos was addressed in [58870].The
has_in_scopetodos were addressed in [58867].This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.