Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
anton-vlasenko
left a comment
There was a problem hiding this comment.
Thank you for your PR, @devansh016!
I agree that a 500 error code doesn't seem the most appropriate for these situations.
However, the wp_insert_term() function is primarily designed for inserting terms and should not be aware of the REST API, as handling such requests is outside its intended scope.
In my opinion, implementing these error codes should be handled within the WP_REST_Terms_Controller.
Additionally, having unit tests for the intended changes would be a great way to ensure they work as expected.
Add http status code to errors earlier they were getting error code 500.
Trac ticket: https://core.trac.wordpress.org/ticket/61843
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.