HTML API: Add tests for virtual node breadcrumbs and depth#6929
HTML API: Add tests for virtual node breadcrumbs and depth#6929sirreal wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Committed with https://core.trac.wordpress.org/changeset/58592. |
| if ( 'open' === $expect_open_close ) { | ||
| $this->assertFalse( $processor->is_tag_closer(), "Found closer when opener expected at {$processor->get_tag()}." ); | ||
| } else { | ||
| $this->assertTrue( $processor->is_tag_closer(), "Found opener when closer expected at {$processor->get_tag()}." ); |
There was a problem hiding this comment.
for tests it's probably helpful to use get_token_name() since if it gets off track on something that isn't a tag this will turn into an empty string when casting from false for the interpolation
| $processor->next_token(); | ||
| } | ||
|
|
||
| $this->assertSame( $expected_tag_name, $processor->get_tag(), "Found incorrect tag name {$processor->get_tag()}." ); |
There was a problem hiding this comment.
Noted in #6765 I generally try to avoid duplicating content in the test failure when it's already reported. Either it's simple enough to let the error say "Failed to find expected tag name" or we add some new and useful information in the interpolation. It's never worth repeating the invalid information in my opinion, because that only repeats that the test failed instead of clueing someone in to what it should be or how they can make it right.
|
I'll address some follow-up test tweaks in #7030. |
Add unit tests for virtual node breadcrumbs and depth. This includes tests for behaviors that were fixed in #6914 / https://core.trac.wordpress.org/changeset/58590.
Trac ticket: https://core.trac.wordpress.org/ticket/61348
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.