Skip to content

Section Styles: Add slug to solve inconsistency in variation names#6824

Closed
aaronrobertshaw wants to merge 3 commits intoWordPress:trunkfrom
aaronrobertshaw:fix/inconsistency-between-block-style-variation-names
Closed

Section Styles: Add slug to solve inconsistency in variation names#6824
aaronrobertshaw wants to merge 3 commits intoWordPress:trunkfrom
aaronrobertshaw:fix/inconsistency-between-block-style-variation-names

Conversation

@aaronrobertshaw
Copy link
Copy Markdown

@aaronrobertshaw aaronrobertshaw commented Jun 14, 2024 •
edited
Loading

Backports the PHP changes from WordPress/gutenberg#62550 fixing an issue with duplicate block style options appearing and variation definitions from different sources not merging correctly.

Test Instructions:

  1. Register a block style variation via register_block_style snippet below
		register_block_style(
			'core/group',
			array(
				'name'         => 'MyVariation',
				'label'        => __( 'My variation', 'twentytwentyfour' ),
				'inline_style' => '
				.is-style-MyVariation {
					background-color: red;
				}',
			)
		);
  1. Create theme.json partial file within /styles/partial.json using the following snippet
{
    "$schema": "https://schemas.wp.org/trunk/theme.json",
    "version": 2,
    "title": "My variation",
    "slug": "MyVariation",
    "blockTypes": [ "core/group" ],
    "styles": {
            "color": {
                    "background": "blue",
                    "text": "white"
            }
    }
}
  1. Open the site editor, select a group block and confirm only a single block style option other than default
  2. Select that block style and confirm that the partial theme.json files' style applies correctly

Unit Tests:

npm run test:php -- --filter WP_Block_Supports_Block_Style_Variations_Test

npm run test:php -- --filter Tests_Theme_wpThemeJsonResolver

Trac ticket: https://core.trac.wordpress.org/ticket/61440

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 14, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, oandregal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronrobertshaw aaronrobertshaw mentioned this pull request Jun 14, 2024
Merged
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 14, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@oandregal oandregal self-requested a review June 14, 2024 07:41
@oandregal
Copy link
Copy Markdown
Member

oandregal commented Jun 14, 2024

Committed at https://core.trac.wordpress.org/changeset/58413

@oandregal oandregal closed this Jun 14, 2024
@ellatrix ellatrix mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oandregal oandregal oandregal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronrobertshaw @oandregal