Clear theme json data between theme unit tests#6696
Clear theme json data between theme unit tests#6696joemcgill wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for spotting this! The change makes sense and the tests are now passing when run individually. Fwiw I couldn't reproduce the failure when running npm run test:php -- --filter test_third_party_blocks_inline_styles_for_elements_get_rendered on trunk, but it's reproducible on this branch if I remove $this->set_up_third_party_block(); from the test. LGTM!
This clears the theme json related caches in the
WP_Theme_UnitTestCase:::tear_down()method to avoid cross pollution between tests when a theme is changed during a test run and fixes a few tests that were only passing by relying on this cross pollution.Trac ticket: https://core.trac.wordpress.org/ticket/61337
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.