Backport: Block Styles: Allow registration of block styles across block types and include style data#6609
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
talldan
left a comment
There was a problem hiding this comment.
Changes look good to me, thanks for adding tests
tellthemachines
left a comment
There was a problem hiding this comment.
Changes LGTM and testing locally with the instructions from WordPress/gutenberg#61029 works as expected!
|
Committed in r58246. |
Adds to core the functionality from:
The Gutenberg PR linked above was forced to add a new global function because the core
WP_Block_Styles_Registryclass was marked asfinal. This backport involves updating theWP_Block_Styles_Registryclass directly with matching functionality.Included is the addition of
style_datawithin the supported style properties. Thestyle_dataproperty is a theme.json shaped array that will be used by the new section styling feature to generate a dynamic stylesheet for the block style.Trac ticket: https://core.trac.wordpress.org/ticket/61274
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.