Global Styles: Update util for scoping CSS selectors#6478
Global Styles: Update util for scoping CSS selectors#6478aaronrobertshaw wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
We try to more consistently use "Added" instead of "Add" in `since` mentions. See https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#docblock-formatting:~:text=%40since%203.8.0%20Added%20the%20%60post__in%60%20argument.
|
Thanks for fixing up the docblock comment @audrasjb 🚀 |
| * @param string $selector Original selector. | ||
| * @return string Scoped selector. | ||
| */ | ||
| public static function scope_selector( $scope, $selector ) { |
There was a problem hiding this comment.
Would be nice if there were a test for this, but given that it's an existing function I think it's fine to do that separately (and tests can be added anytime during the release cycle).
|
Committed in r58245. |
Syncs the changes from:
Adds early return for existing scope_selector method making it more robust and ready for extending block style variations. See: WordPress/gutenberg#57908
Unit tests:
npm run test:php -- --filter Tests_Theme_wpThemeJsonTrac ticket: https://core.trac.wordpress.org/ticket/61120
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.