Add Style Engine support for nested CSS rules.#6460
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Tests added, marking this ready for review! |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
left a comment
There was a problem hiding this comment.
Thanks for porting over these changes. LGTM
Ran the unit tests and also created some grouped styles manually using wp_style_engine_get_stylesheet_from_css_rules - results were as expected.
🍺
|
|
||
| /** | ||
| * Gets the rules group. | ||
| * |
There was a problem hiding this comment.
Should new methods and updates to other public methods/APIs get a @since annotation?
There was a problem hiding this comment.
Oh good point, yeah they should!
|
Committed in r58089. |
Trac ticket: https://core.trac.wordpress.org/ticket/61099
Syncs the changes from WordPress/gutenberg#58867 and WordPress/gutenberg#58922.
This isn't really testable without a code change; you can check out usage in this PR (which will be also synced to Core in this release cycle).
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.