Using the 'paged' var if the singular page is the front page#6421
Using the 'paged' var if the singular page is the front page#6421Rajinsharwar wants to merge 8 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
This pull request looks good to me.
@Rajinsharwar I took the liberty of merging in trunk and adding a second test to make sure this doesn't affect sites using the blog archive on the home page.
hellofromtonya
left a comment
There was a problem hiding this comment.
- Source code changes align to the original changes in PR #270 ✅
- Has unit tests ✅
- Running unit tests locally:
npm run test:phptests pass ✅- with
-- --group canonicaltests pass ✅ - with
-- --group 50163tests pass ✅ - with
-- --filter Tests_Canonical_Pagedtests pass ✅
- Manual testing in local browser works as expected and resolves the bug:
LGTM for commit 👍
|
Committed via https://core.trac.wordpress.org/changeset/59091. |
|
Reopening as r59091 was reverted by https://core.trac.wordpress.org/changeset/59133. Why? It caused a BC break for a static homepage that includes a shortcode's or block's with paginated content that uses the 'paged' query var, e.g. bbPress (details are here in the Trac ticket). Resetting the PR approvals. |
Using the 'paged' var if the singular page is the front page with unit tests
Trac ticket: https://core.trac.wordpress.org/ticket/50163
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.