Twenty Twenty-Three: Extract pagination into pattern#6403
Conversation
This adds translation support to the pagination-previous and pagination-next labels.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Following some thorough feedback by @carolinan, it makes most sense to close this PR. This change would be a BC break (only functioning from WordPress 6.6) and by closing this, anyone can start fresh on a backwards compatible change. |
This extracts the pagination into a pattern, which adds translation support to the pagination-previous and pagination-next labels.
Trac ticket: https://core.trac.wordpress.org/ticket/60298
Testing Instructions
On your WordPress installation, make sure that you have enough posts to enable pagination on archives.
Download and install Twenty Twenty-Three.
Note
At the time of writing, this only seems to work with the current Gutenberg plugin active.
Note
The labels currently aren't translated in the
twentytwentythreedomain. I removed the domain in theesc_html_ecalls in the pagination pattern to utilize the translations from the root domain that have been translated for thelink_template.phpfile.View the front of the site, confirm that the pagination blocks are visible on your homepage, an archive page, and the search page. Navigate to the next page. Verify you're on the right url. Verify the labels are showing correct and the previous and next navigation points again to the right pages.
Go to settings > general and change your site language.
Once more, view the front of the site and confirm that the pagination blocks are visible on your homepage, an archive page, and the search page. The labels should be translated. Navigate to the next page. Verify you're on the right url. Verify the labels are showing correct and are translated, and the previous and next navigation points again to the right pages.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.