Fix regression with theme.json settings.shadow.defaultPresets (minimal)#6303
Closed
ajlende wants to merge 8 commits intoWordPress:trunkfrom
Closed
Fix regression with theme.json settings.shadow.defaultPresets (minimal)#6303ajlende wants to merge 8 commits intoWordPress:trunkfrom
settings.shadow.defaultPresets (minimal)#6303ajlende wants to merge 8 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Mar 21, 2024
Member
|
Looks like we're converging towards focusing on #6309, so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All discussion for this issue should be done in WordPress/gutenberg#59989
Alternative to #6295 without the
editor-shadow-presetstheme support feature.The color/gradient support behavior that I think we should be matching enables support for the presets in classic themes by default and allows themes to opt-out. For example, gradients can be opted-out of by setting
add_theme_support( 'editor-gradient-presets', array() ).If we're okay with shadows being opt-out in the UI like colors/gradients, we can merge just this and add the ability to opt-out with
add_theme_support( 'editor-shadow-presets', array() )that's included in #6295 as a follow-up in 6.6.Trac ticket: https://core.trac.wordpress.org/ticket/60815
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.