Doc block fix for WP_Block_Patterns_Registry::register#6191
Doc block fix for WP_Block_Patterns_Registry::register#6191kt-12 wants to merge 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
joemcgill
left a comment
There was a problem hiding this comment.
Good update. The $content property should be updated to say that it is no longer required if there is a $file_path present. It would probably be good to move the new property up to just after $content as well, since they are so closely related. What do you think?
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joemcgill
left a comment
There was a problem hiding this comment.
After looking at this again, @kt-12 and I realized that the new property is the only one using snake case instead of camel case. Let's go ahead and fix those now for consistency and add, a @since annotation to the register method here.
* @since 6.5.0 Added support for the `filePath` property.
Trac ticket: https://core.trac.wordpress.org/ticket/59532
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.