Conversation
Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joemcgill
left a comment
There was a problem hiding this comment.
These tests look good, just a couple of small nitpicks. Thanks @kt-12.
My main question about this is that by running the get_all_registered() or get_registered() methods against the main WP_Block_Patterns_Registry class instance, we are modifying the shape of the patterns in the registry, which could impact other tests.
It makes me wonder if we should really modify the tear_down method in this class so that it will properly reset the registry to a known state at the end of each test method or if we can rewrite these tests using the private $registry property that is created during the set_up method for this class? What do you think?
grammar fix Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
grammar fix Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
joemcgill
left a comment
There was a problem hiding this comment.
I really like the updates to the set_up and tear_down helpers here. I think ensuring that we are resetting the registry state after each test will be much cleaner.
Trac ticket: https://core.trac.wordpress.org/ticket/59532
Added unit test for #59532
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.